Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify makefiles #353

Merged
merged 13 commits into from
Nov 13, 2023
Merged

Simplify makefiles #353

merged 13 commits into from
Nov 13, 2023

Conversation

jpswinski
Copy link
Member

@jpswinski jpswinski commented Nov 8, 2023

We previously had three different places where the sliderule system was build: the root makefile, the slideruleearth-aws makefile, and the dockerfile. This led to unnecessary coordination between the three places and also some inconsistencies in the way the code was built.

The goal is to have only one place where the code is built - the slideruleearth-aws makefile.

Changes:

  • Removed plugin builds from root makefile
  • Removed ENABLE_COMPAT option that supported CentOS 7
  • Standardize on C++17 for all plugins
  • GitHub workflow for selftest uses the slideruleearth-aws build
  • Captured build dependencies in a lock file
  • Added pistache, clang, cppcheck to the build environment
  • Selftest GitHub workflow runs address sanitizer - removed valgrind from workflows
  • Made unit tests in C++ code conditional on debug build
  • Added a target that uses atlas plugin so that we can verify that it builds and runs

@jpswinski jpswinski requested a review from elidwa November 9, 2023 14:00
@elidwa
Copy link
Contributor

elidwa commented Nov 13, 2023

I reviewed the changes and they look good. I propose to merge it to main. With this code merged into main I will use it to switch to sliderule/targets/slideruleearth-aws as my dev location. We can then remove root makefiles.

@jpswinski jpswinski merged commit fa20fcb into main Nov 13, 2023
4 of 5 checks passed
@jpswinski jpswinski deleted the narrowmake branch November 13, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants